Quantcast

php 5.4 issues: htmlspecialchars, session_unregister

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

php 5.4 issues: htmlspecialchars, session_unregister

Alexander Zubkov-2
Hi. I was having some issues with squirrelmail-1.4.* (including stable
SVN) after migrating to php 5.4:

1) function/i18n.php in function charset_decode have call to
htmlspecialchars, which was using charset ISO-8859-1 as default and now
it is UTF-8. Because of that it cuts all non-ASCII characters, for
example, in message with KOI8-R charset. I replaced its call to:
htmlspecialchars($string, ENT_COMPAT | ENT_HTML401, 'ISO-8859-1')
This function seems to be changed in version 1.5, but 1.4 users are
still unhappy.

2) plugins/message_details/message_details_bottom.php have call to
function session_unregister, which was deprecated in php 5.3 and removed
in 5.4


------------------------------------------------------------------------------
How fast is your code?
3 out of 4 devs don\\\'t know how their code performs in production.
Find out how slow your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219672;13503038;z?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: [hidden email]
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: php 5.4 issues: htmlspecialchars, session_unregister

Paul Lesniewski
On Sat, Sep 15, 2012 at 10:14 AM, Alexander Zubkov <[hidden email]> wrote:

> Hi. I was having some issues with squirrelmail-1.4.* (including stable
> SVN) after migrating to php 5.4:
>
> 1) function/i18n.php in function charset_decode have call to
> htmlspecialchars, which was using charset ISO-8859-1 as default and now
> it is UTF-8. Because of that it cuts all non-ASCII characters, for
> example, in message with KOI8-R charset. I replaced its call to:
> htmlspecialchars($string, ENT_COMPAT | ENT_HTML401, 'ISO-8859-1')
> This function seems to be changed in version 1.5, but 1.4 users are
> still unhappy.

This issue is known and being worked on.  There were some threads
about it on the users mailing list recently you can refer to.

> 2) plugins/message_details/message_details_bottom.php have call to
> function session_unregister, which was deprecated in php 5.3 and removed
> in 5.4

Thanks for finding this.  I just committed a fix for this.

--
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: [hidden email]
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Loading...