mailbox_display.php patch php7.0 Ubuntu16.04 nginx

classic Classic list List threaded Threaded
2 messages Options
jo3
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

mailbox_display.php patch php7.0 Ubuntu16.04 nginx

jo3
Hi, All;

mailbox_display.php was producing bad locations after upgrade.

Had to use php basename() on locations.

Patch listed below.

Thanks,

Jo3

--- /squirrelmail/functions/mailbox_display.php 2016-01-01
12:04:30.000000000 -0800
+++ /squirrelmailu1604/functions/mailbox_display.php 2016-05-11
16:42:27.779936838 -0700
@@ -797,6 +797,7 @@
     } else {
         $location = $php_self;
     }
+    $location = basename($location);

 //    $location = urlencode($location);

@@ -954,6 +955,7 @@
         $source_url = $PHP_SELF;
     }

+    $source_url = basename($source_url);
     /* Now that we have everything figured out, show the actual button. */
     echo ' <a href="' . $source_url .'?newsort=' . $which
          . '&amp;startMessage=1&amp;mailbox=' . urlencode($mailbox)




------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: [hidden email]
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: mailbox_display.php patch php7.0 Ubuntu16.04 nginx

Paul Lesniewski
On 5/11/16, [hidden email] <[hidden email]> wrote:
> Hi, All;
>
> mailbox_display.php was producing bad locations after upgrade.
>
> Had to use php basename() on locations.

That means something broke with Ubuntu's downstream code or with your
configuration.  We appreciate the patch submission, but the problem
would be better addressed looking at your configuration and/or
Ubuntu's customizations.


> Patch listed below.
>
> Thanks,
>
> Jo3
>
> --- /squirrelmail/functions/mailbox_display.php 2016-01-01
> 12:04:30.000000000 -0800
> +++ /squirrelmailu1604/functions/mailbox_display.php 2016-05-11
> 16:42:27.779936838 -0700
> @@ -797,6 +797,7 @@
>      } else {
>          $location = $php_self;
>      }
> +    $location = basename($location);
>
>  //    $location = urlencode($location);
>
> @@ -954,6 +955,7 @@
>          $source_url = $PHP_SELF;
>      }
>
> +    $source_url = basename($source_url);
>      /* Now that we have everything figured out, show the actual button. */
>      echo ' <a href="' . $source_url .'?newsort=' . $which
>           . '&amp;startMessage=1&amp;mailbox=' . urlencode($mailbox)

--
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: [hidden email]
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Loading...