Spam Folder

classic Classic list List threaded Threaded
37 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Spam Folder

PajaP
Hi

This has not been replied to in users list so maybe it is more
appropriate here.

Are there any plans to ever include a spam/junk folder in the core
squirrelmail build?

I would find this to be a very welcome addition.

I currently do this myself but have to make hacks to left_main.php,
config.php, and conf.pl (so it does not undo the changes I make to
config.php every time I use it to add a plugin or make other changes)
Also so the spam/junk folder cannot be deleted, renamed etc.

I also have to add my own custom icon to the images folder so it does
not use the default folder icon.

I am also using the junkfolder plugin and have to make a few changes
to this so it works how I like.
Though I could do without this plugin if I made additional hacks to
the source (maybe also in imap_mailbox.php?).

All these changes mean it is quite a lengthy process each time I want
to upgrade my squirrelmail install.

Anyhow if it is not planned to be added I would like to request it is.

Apart from this squirrelmail is an amazing package, especially given
the price ;) Thanks for all your work.

--
Many thanks
PajaP


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: [hidden email]
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|

Re: Spam Folder

Brian G. Peterson
On Wednesday 06 September 2006 11:18, PajaP wrote:

> Hi
>
> This has not been replied to in users list so maybe it is more
> appropriate here.
>
> Are there any plans to ever include a spam/junk folder in the core
> squirrelmail build?
>
> I would find this to be a very welcome addition.
>
> I currently do this myself but have to make hacks to left_main.php,
> config.php, and conf.pl (so it does not undo the changes I make to
> config.php every time I use it to add a plugin or make other changes)
> Also so the spam/junk folder cannot be deleted, renamed etc.
>
> I also have to add my own custom icon to the images folder so it does
> not use the default folder icon.
>
> I am also using the junkfolder plugin and have to make a few changes
> to this so it works how I like.
> Though I could do without this plugin if I made additional hacks to
> the source (maybe also in imap_mailbox.php?).
>
> All these changes mean it is quite a lengthy process each time I want
> to upgrade my squirrelmail install.
>
> Anyhow if it is not planned to be added I would like to request it is.
>
> Apart from this squirrelmail is an amazing package, especially given
> the price ;) Thanks for all your work.

Use the special_folders plugin and/or one of the spam filter plugins.  
There is no need for this in the core, as different spam filtering
systems handle it differently, and it is adequately solved by the plugins
designed for this purpose.

Regards,

  - Brian


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: [hidden email]
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|

Re: Spam Folder

PajaP
On Wed, 6 Sep 2006 11:58:38 -0500, "Brian G. Peterson"
<[hidden email]> wrote:

>On Wednesday 06 September 2006 11:18, PajaP wrote:
>> Hi
>>
>> This has not been replied to in users list so maybe it is more
>> appropriate here.
>>
>> Are there any plans to ever include a spam/junk folder in the core
>> squirrelmail build?
>>
>> I would find this to be a very welcome addition.
>>
>> I currently do this myself but have to make hacks to left_main.php,
>> config.php, and conf.pl (so it does not undo the changes I make to
>> config.php every time I use it to add a plugin or make other changes)
>> Also so the spam/junk folder cannot be deleted, renamed etc.
>>
>> I also have to add my own custom icon to the images folder so it does
>> not use the default folder icon.
>>
>> I am also using the junkfolder plugin and have to make a few changes
>> to this so it works how I like.
>> Though I could do without this plugin if I made additional hacks to
>> the source (maybe also in imap_mailbox.php?).
>>
>> All these changes mean it is quite a lengthy process each time I want
>> to upgrade my squirrelmail install.
>>
>> Anyhow if it is not planned to be added I would like to request it is.
>>
>> Apart from this squirrelmail is an amazing package, especially given
>> the price ;) Thanks for all your work.
>
>Use the special_folders plugin and/or one of the spam filter plugins.  
>There is no need for this in the core, as different spam filtering
>systems handle it differently, and it is adequately solved by the plugins
>designed for this purpose.
>

I tried the user_special_mailboxes plugin once but it did not allow me
to set a special icon for it. Maybe this has changed.
Also the folder is not 'really' special in the way that Inbox, Sent,
Drafts and Trash are. Folders set using the plugin can be deleted,
renamed and unsubscribed.
I know users can change the folder used as Trash, Draft and Sent but
once defined they do not appear in the unsubscribe, delete and rename
lists. I personally do not think there is any need for end user to
change the names (or use a different folder) to the one I set and now
I think about it I am also going to remove the option of allowing
this.

The user_special_mailboxes plugin has its uses but for me, this is not
for defining a spam folder (this should be set by the admin). The only
real use for it, imo, is to change the order of folders, bringing
(most used) folders higher up the list.

I use the junk_folder plugin as it also gives a message explaining
what the folder is used for at the top of the list. Though I could
easily do without this if the spam folder was defined in core (and
having it automatically created if it did not exist would be an even
bigger benefit).

I think there is a need for this to be put into core.
If admin's did not want to use it they could disable it. The same as
they can for Drafts, with maybe an additional option 'By default, use
Spam folder'.
A special icon could be set for the spam folder in the core code.

Yes, there would still be an need to use additional plugins to move
folders to the spam folder (I currently use the built in 'filters'
plugin to do just this (if my mail server supported moving/filtering
messages to individual user folders I would not even use this plugin).
Combined with the spam_buttons plugin this works really well.

I just have to go to the extra effort of hacking the code to get it
set-up like a 'regular' special folder, including hacks to config.pl

Am I really the only admin that would like to see this?

--
Thanks
PajaP



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: [hidden email]
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|

Re: Spam Folder

Tomas Kuliavas
>>> Hi
>>>
>>> This has not been replied to in users list so maybe it is more
>>> appropriate here.
>>>
>>> Are there any plans to ever include a spam/junk folder in the core
>>> squirrelmail build?
>>>
>>> I would find this to be a very welcome addition.
>>>
>>> I currently do this myself but have to make hacks to left_main.php,
>>> config.php, and conf.pl (so it does not undo the changes I make to
>>> config.php every time I use it to add a plugin or make other changes)
>>> Also so the spam/junk folder cannot be deleted, renamed etc.
>>>
>>> I also have to add my own custom icon to the images folder so it does
>>> not use the default folder icon.
>>>
>>> I am also using the junkfolder plugin and have to make a few changes
>>> to this so it works how I like.
>>> Though I could do without this plugin if I made additional hacks to
>>> the source (maybe also in imap_mailbox.php?).
>>>
>>> All these changes mean it is quite a lengthy process each time I want
>>> to upgrade my squirrelmail install.
>>>
>>> Anyhow if it is not planned to be added I would like to request it is.
>>>
>>> Apart from this squirrelmail is an amazing package, especially given
>>> the price ;) Thanks for all your work.
>>
>>Use the special_folders plugin and/or one of the spam filter plugins.
>>There is no need for this in the core, as different spam filtering
>>systems handle it differently, and it is adequately solved by the plugins
>>designed for this purpose.
>>
>
> I tried the user_special_mailboxes plugin once but it did not allow me
> to set a special icon for it. Maybe this has changed.
> Also the folder is not 'really' special in the way that Inbox, Sent,
> Drafts and Trash are. Folders set using the plugin can be deleted,
> renamed and unsubscribed.
> I know users can change the folder used as Trash, Draft and Sent but
> once defined they do not appear in the unsubscribe, delete and rename
> lists. I personally do not think there is any need for end user to
> change the names (or use a different folder) to the one I set and now
> I think about it I am also going to remove the option of allowing
> this.
>
> The user_special_mailboxes plugin has its uses but for me, this is not
> for defining a spam folder (this should be set by the admin). The only
> real use for it, imo, is to change the order of folders, bringing
> (most used) folders higher up the list.
>
> I use the junk_folder plugin as it also gives a message explaining
> what the folder is used for at the top of the list. Though I could
> easily do without this if the spam folder was defined in core (and
> having it automatically created if it did not exist would be an even
> bigger benefit).
>
> I think there is a need for this to be put into core.
> If admin's did not want to use it they could disable it. The same as
> they can for Drafts, with maybe an additional option 'By default, use
> Spam folder'.
> A special icon could be set for the spam folder in the core code.
>
> Yes, there would still be an need to use additional plugins to move
> folders to the spam folder (I currently use the built in 'filters'
> plugin to do just this (if my mail server supported moving/filtering
> messages to individual user folders I would not even use this plugin).
> Combined with the spam_buttons plugin this works really well.
>
> I just have to go to the extra effort of hacking the code to get it
> set-up like a 'regular' special folder, including hacks to config.pl
>
> Am I really the only admin that would like to see this?

Folder tree can use icons only in 1.5.x. I think you are right that
plugins can't control used folder icon. But SquirrelMail folder management
script does not allow unsubscribing, renaming or deleting special
mailboxes in 1.5.1 and current 1.5.2cvs. If you can do that, show md5sum
and id string of your src/folders.php file.

--
Tomas

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: [hidden email]
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|

Re: Spam Folder

michael (Bugzilla)-10
Just food for thought.. In our MagicMail Servers, we have the Spam folders
automatically created by the mail server.  Although it would save us the step
of creating this, if a mail server already creates something by a different
name, ie 'JunkMail' then it would be redundant to have 'Spam' folders, and
this can be confusing, and people would have to hack it NOT to show by
default.

Maybe this is better set as config options in squirrelmail, ie directories to
create if they do not exist.  These automatically created folders could have
some special connatation, or meaning that Squirrelmail would recognize, and
maybe prevent deletion etc.  However, these are standard IMAP folders
anyways, so this is not just the purvey of Squirrelmail

I think this can be addressed without the use of a plugin.  Or it should be
left to the mail server admin. On our mail servers, if someone were to delete
the folder Spam, it gets recreated.  Other servers may have specialized
business rules on folders used for Spam already as well.

On September 6, 2006 12:25 pm, Tomas Kuliavas wrote:

> > Yes, there would still be an need to use additional plugins to move
> > folders to the spam folder (I currently use the built in 'filters'
> > plugin to do just this (if my mail server supported moving/filtering
> > messages to individual user folders I would not even use this plugin).
> > Combined with the spam_buttons plugin this works really well.
> >
> > I just have to go to the extra effort of hacking the code to get it
> > set-up like a 'regular' special folder, including hacks to config.pl
> >
> > Am I really the only admin that would like to see this?
>
> Folder tree can use icons only in 1.5.x. I think you are right that
> plugins can't control used folder icon. But SquirrelMail folder management
> script does not allow unsubscribing, renaming or deleting special
> mailboxes in 1.5.1 and current 1.5.2cvs. If you can do that, show md5sum
> and id string of your src/folders.php file.

--
"Catch the Magic of Linux..."
--------------------------------------------------------
Michael Peddemors - Senior Systems Developer
LinuxAdministration - Internet Services
NetworkServices - Programming - Security
Wizard IT Services http://www.wizard.ca 
Linux Support Specialist - http://www.linuxmagic.com
LinuxMagic is a Registered TradeMark of Wizard Tower TechnoServices Ltd.
--------------------------------------------------------
(604)589-0037 Beautiful British Columbia, Canada

This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to which they
are addressed. If you have received this email in error please notify
the system manager. Please note that any views or opinions presented in
this email are solely those of the author and do not necessarily
represent those of the company.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: [hidden email]
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|

Re: Spam Folder

PajaP
In reply to this post by Tomas Kuliavas
On Wed, 6 Sep 2006 22:25:55 +0300 (EEST), "Tomas Kuliavas"
<[hidden email]> wrote:

>Folder tree can use icons only in 1.5.x. I think you are right that
>plugins can't control used folder icon. But SquirrelMail folder management
>script does not allow unsubscribing, renaming or deleting special
>mailboxes in 1.5.1 and current 1.5.2cvs. If you can do that, show md5sum
>and id string of your src/folders.php file.
>

Just to confirm.
I use 1.4.8 and I _cannot_ delete, rename or unsubscribe the default 4
special folders, Inbox, Drafts, Sent and Trash in a 'vanilla' install.

It is only when a _new_ special folder is created that one of the
special folders can be deleted, renamed or unsubscribed. Either 'Spam'
or 'Trash'.
I currently get around this by editing src/folders.php

-----------------
if ((strtolower($boxes[$i]["unformatted"]) != "inbox") &&
    ($boxes[$i]["unformatted"] != $trash_folder) &&
    ($boxes[$i]["unformatted"] != $sent_folder) &&
-----------------

Changed to:
-----------------
if ((strtolower($boxes[$i]["unformatted"]) != "inbox") &&
    ($boxes[$i]["unformatted"] != $trash_folder) &&
    ($boxes[$i]["unformatted"] != $sent_folder) &&
    ($boxes[$i]["unformatted"] != $spam_folder) &&
-----------------
This prevents the Spam folder from being unsubscribed.

-------------------------------------
-------------------------------------

Then:
-----------------
case $sent_folder:
    ++$count_special_folders;
    $skip_folders[] = $sent_folder;
    break;
-----------------

Underneath I add:
-----------------
case $spam_folder:
    ++$count_special_folders;
    $skip_folders[] = $spam_folder;
    break;
-----------------
This prevents the Spam folder from being deleted or renamed
but unfortunately allows the Trash folder to be deleted or renamed.

-------------------------------------
-------------------------------------

Then:
-----------------
$count_special_folders = 0;
-----------------

Changed to:
-----------------
$count_special_folders = -1;
-----------------
This fixes the problem of the Trash folder being able to be
deleted/renamed as a result of the previous fix above.

Probably not he best way of coding all this but it works for me
without any php or sm errors/problems.

I also have hacks to change the Spam folder icon but (as a small part
of this) I have to change config.php by adding the line:

---------------------------------------------------
$spam_folder                   = 'Spam';
---------------------------------------------------

However whenever I use conf.pl to make any changes the line above is
obviously removed.
I have hacked conf.pl so it does not remove the above line from
config.php.

All not very graceful and doing this each time I upgrade is a bit of a
pain (especially as I have to also modify several other files to get
the Spam folder icon working etc. I am sure a php developer could do
it much better.
I do have it all documented but still takes quite a bit of time.

Hence my request to have a Spam folder 'option' as part of the source.

--
Thanks
PajaP


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: [hidden email]
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|

Re: Spam Folder

PajaP
In reply to this post by michael (Bugzilla)-10
On Wed, 6 Sep 2006 12:34:22 -0700, Michael Peddemors
<[hidden email]> wrote:

>Just food for thought.. In our MagicMail Servers, we have the Spam folders
>automatically created by the mail server.  Although it would save us the step
>of creating this, if a mail server already creates something by a different
>name, ie 'JunkMail' then it would be redundant to have 'Spam' folders, and
>this can be confusing, and people would have to hack it NOT to show by
>default.
>
>Maybe this is better set as config options in squirrelmail, ie directories to
>create if they do not exist.  These automatically created folders could have
>some special connatation, or meaning that Squirrelmail would recognize, and
>maybe prevent deletion etc.  However, these are standard IMAP folders
>anyways, so this is not just the purvey of Squirrelmail
>
>I think this can be addressed without the use of a plugin.  Or it should be
>left to the mail server admin. On our mail servers, if someone were to delete
>the folder Spam, it gets recreated.  Other servers may have specialized
>business rules on folders used for Spam already as well.
>

Thanks Michael.
This is exactly how I would like it.

--
PajaP


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: [hidden email]
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|

Re: Spam Folder

Paul Lesniewski
On 9/6/06, PajaP <[hidden email]> wrote:

> On Wed, 6 Sep 2006 12:34:22 -0700, Michael Peddemors
> <[hidden email]> wrote:
>
> >Just food for thought.. In our MagicMail Servers, we have the Spam folders
> >automatically created by the mail server.  Although it would save us the step
> >of creating this, if a mail server already creates something by a different
> >name, ie 'JunkMail' then it would be redundant to have 'Spam' folders, and
> >this can be confusing, and people would have to hack it NOT to show by
> >default.
> >
> >Maybe this is better set as config options in squirrelmail, ie directories to
> >create if they do not exist.  These automatically created folders could have
> >some special connatation, or meaning that Squirrelmail would recognize, and
> >maybe prevent deletion etc.  However, these are standard IMAP folders
> >anyways, so this is not just the purvey of Squirrelmail
> >
> >I think this can be addressed without the use of a plugin.  Or it should be
> >left to the mail server admin. On our mail servers, if someone were to delete
> >the folder Spam, it gets recreated.  Other servers may have specialized
> >business rules on folders used for Spam already as well.
> >
>
> Thanks Michael.
> This is exactly how I would like it.

I think Michael is suggesting (if he's not, I am) that the underlying
system takes care of it.  Not only is it out of the purview of a
plugin, it is out of the purview of SM.  SM is a client, not a mail
system manager.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: [hidden email]
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|

Re: Spam Folder

Brian G. Peterson
On Thursday 07 September 2006 00:15, Paul Lesniewski wrote:

> > <[hidden email]> wrote:
> > >Maybe this is better set as config options in squirrelmail, ie
> > > directories to create if they do not exist.  These automatically
> > > created folders could have some special connatation, or meaning
> > > that Squirrelmail would recognize, and maybe prevent deletion etc.
> > >  However, these are standard IMAP folders anyways, so this is not
> > > just the purvey of Squirrelmail
> > >
> > > I think this can be addressed without the use of a plugin.  Or it
> > > should be left to the mail server admin. On our mail servers, if
> > > someone were to delete the folder Spam, it gets recreated.  Other
> > > servers may have specialized business rules on folders used for
> > > Spam already as well.
>
> I think Michael is suggesting (if he's not, I am) that the underlying
> system takes care of it.  Not only is it out of the purview of a
> plugin, it is out of the purview of SM.  SM is a client, not a mail
> system manager.

I agree that there's some utility to having the "Special Folders" have a
different sorting and look than regular folders, and this may be
accomplished by a plugin.  But the name, location, etc of the folder, and
how they work, is not really a client issue.

Regards,

   - Brian

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: [hidden email]
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|

Re: Spam Folder

PajaP
In reply to this post by Paul Lesniewski
On Wed, 6 Sep 2006 22:15:12 -0700, "Paul Lesniewski"
<[hidden email]> wrote:

>I think Michael is suggesting (if he's not, I am) that the underlying
>system takes care of it.  Not only is it out of the purview of a
>plugin, it is out of the purview of SM.  SM is a client, not a mail
>system manager.
>

"Maybe this is better set as config options in squirrelmail, ie
directories to create if they do not exist".

I don't know what reason there is for any objection to adding this to
SM. To me it seems logical and appropriate it is added.
Squirrelmail already creates my 3 other special folders, Drafts, Sent
and Trash so why not a Spam one.

_Every_ other 'major player' webmail site out there has a SPAM folder
(as a special folder).

Whatever, I will keep modifying the code myself to do what I want.
Until I get fed up with this and make my users move to Thunderbird.
Which incidentally does have the option to create a Spam folder as a
special folder with a plugin or extension (as does just about every
other client I have used).

No-one has provided a good argument for not adding this in.
If no-one wants to take on the coding, I see this as a valid reason ;)

I don't see it as being out of the purview of SM when every other
client already does it.

Why not move with the times?

--
Thanks
PajaP


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: [hidden email]
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|

Re: Spam Folder

Tomas Kuliavas
>>I think Michael is suggesting (if he's not, I am) that the underlying
>>system takes care of it.  Not only is it out of the purview of a
>>plugin, it is out of the purview of SM.  SM is a client, not a mail
>>system manager.
>>
>
> "Maybe this is better set as config options in squirrelmail, ie
> directories to create if they do not exist".
>
> I don't know what reason there is for any objection to adding this to
> SM. To me it seems logical and appropriate it is added.
> Squirrelmail already creates my 3 other special folders, Drafts, Sent
> and Trash so why not a Spam one.
>
> _Every_ other 'major player' webmail site out there has a SPAM folder
> (as a special folder).

And what you are supposed to do with that folder? Nothing, if you don't
have tools that do spam filtering.

> I don't see it as being out of the purview of SM when every other
> client already does it.

You use "every other" term to describe something that is present only in
some email clients.

SquirrelMail is IMAP client. Drafts, Sent and Trash are not standard IMAP
folders. Only INBOX is standard one. See RFC 3501.

You are asking for feature that can be implemented as plugin. Point at
bugs in 1.4.x code without saying that they are bugs. Claim that you also
need it for some special feature that is not present in standard code.
Complain that SquirrelMail configuration script removes variable that is
not supposed to be used in standard config.php. Ignore special
configuration file that can be used to store custom variables.

SquirrelMail is modular system. This feature can be implemented in plugin.
Please implement it in plugin. If you can't implement something in plugin,
we have devel and plugins lists for that.

--
Tomas

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: [hidden email]
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|

Re: Spam Folder

michael (Bugzilla)-10
On September 7, 2006 09:38 am, Tomas Kuliavas wrote:
> >>I think Michael is suggesting (if he's not, I am) that the underlying
> >>system takes care of it.  Not only is it out of the purview of a
> >>plugin, it is out of the purview of SM.  SM is a client, not a mail
> >>system manager.

:) Yes, the underlying system takes care of this,

HOWEVER, in the interests of satisfying implementors of various systems, I did
say that IF this was approached by SQ, since.. as is pointed out below, that
SQ already allows for certain 'specially treated' folders, ie Draft, Sent,
Trash that are there because they make sense, and are convenient to apply
certain special rules, ie they cannot be deleted from within the SQ client,
that possibly give control over to the implementors on 'other' folders that
might be given the same preferential treatment, or other special treatments,
and if that was to be done, the logical place would be a configuration item.

IE.. a permissions config ..

[FOLDER PERMISSIONS]

Draft:AutoCreate:DoNotDestroy:NoExpire
# Spam:AutoCreate:DoNotDestroy:Expire30

You get my drift.  Then if someone like the original reporter of this issue
wanted a Spam Folder, they could uncomment it.  Folder Icons could be based
on the permissions.  And if down the road, someone wants some new 'specially
treated' folder, ie 'Shared Email' for thier specific implementation, then
they have the vehicle in place.

I would say, that IF it was there, MagicMail would set that flag for the Spam
folder, but in our case, we would not use AutoCreate, or Expire, but we would
set the DoNotDestroy flag.

> > "Maybe this is better set as config options in squirrelmail, ie
> > directories to create if they do not exist".
> >
> > I don't know what reason there is for any objection to adding this to
> > SM. To me it seems logical and appropriate it is added.
> > Squirrelmail already creates my 3 other special folders, Drafts, Sent
> > and Trash so why not a Spam one.
> >
> > _Every_ other 'major player' webmail site out there has a SPAM folder
> > (as a special folder).
>
> And what you are supposed to do with that folder? Nothing, if you don't
> have tools that do spam filtering.
>
> > I don't see it as being out of the purview of SM when every other
> > client already does it.
>
> You use "every other" term to describe something that is present only in
> some email clients.
>
> SquirrelMail is IMAP client. Drafts, Sent and Trash are not standard IMAP
> folders. Only INBOX is standard one. See RFC 3501.

--
"Catch the Magic of Linux..."
--------------------------------------------------------
Michael Peddemors - Senior Systems Developer
LinuxAdministration - Internet Services
NetworkServices - Programming - Security
Wizard IT Services http://www.wizard.ca 
Linux Support Specialist - http://www.linuxmagic.com
LinuxMagic is a Registered TradeMark of Wizard Tower TechnoServices Ltd.
--------------------------------------------------------
(604)589-0037 Beautiful British Columbia, Canada

This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to which they
are addressed. If you have received this email in error please notify
the system manager. Please note that any views or opinions presented in
this email are solely those of the author and do not necessarily
represent those of the company.

--
"Catch the Magic of Linux..."
--------------------------------------------------------
Michael Peddemors - Senior Systems Developer
LinuxAdministration - Internet Services
NetworkServices - Programming - Security
Wizard IT Services http://www.wizard.ca 
Linux Support Specialist - http://www.linuxmagic.com
LinuxMagic is a Registered TradeMark of Wizard Tower TechnoServices Ltd.
--------------------------------------------------------
(604)589-0037 Beautiful British Columbia, Canada

This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to which they
are addressed. If you have received this email in error please notify
the system manager. Please note that any views or opinions presented in
this email are solely those of the author and do not necessarily
represent those of the company.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: [hidden email]
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|

Re: Spam Folder

Paul Lesniewski
In reply to this post by Tomas Kuliavas
On 9/7/06, Tomas Kuliavas <[hidden email]> wrote:

> >>I think Michael is suggesting (if he's not, I am) that the underlying
> >>system takes care of it.  Not only is it out of the purview of a
> >>plugin, it is out of the purview of SM.  SM is a client, not a mail
> >>system manager.
> >>
> >
> > "Maybe this is better set as config options in squirrelmail, ie
> > directories to create if they do not exist".
> >
> > I don't know what reason there is for any objection to adding this to
> > SM. To me it seems logical and appropriate it is added.
> > Squirrelmail already creates my 3 other special folders, Drafts, Sent
> > and Trash so why not a Spam one.
> >
> > _Every_ other 'major player' webmail site out there has a SPAM folder
> > (as a special folder).
>
> And what you are supposed to do with that folder? Nothing, if you don't
> have tools that do spam filtering.
>
> > I don't see it as being out of the purview of SM when every other
> > client already does it.
>
> You use "every other" term to describe something that is present only in
> some email clients.
>
> SquirrelMail is IMAP client. Drafts, Sent and Trash are not standard IMAP
> folders. Only INBOX is standard one. See RFC 3501.
>
> You are asking for feature that can be implemented as plugin. Point at
> bugs in 1.4.x code without saying that they are bugs. Claim that you also
> need it for some special feature that is not present in standard code.
> Complain that SquirrelMail configuration script removes variable that is
> not supposed to be used in standard config.php. Ignore special
> configuration file that can be used to store custom variables.
>
> SquirrelMail is modular system. This feature can be implemented in plugin.
> Please implement it in plugin. If you can't implement something in plugin,
> we have devel and plugins lists for that.

Specifically, please suggest the changes (patch) needed to add this as
a feature to the junk folder plugin or the special folders plugin or
other plugin as appropriate.

 -paul

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: [hidden email]
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|

Re: Spam Folder

PajaP
In reply to this post by Tomas Kuliavas
On Thu, 7 Sep 2006 19:38:45 +0300 (EEST), "Tomas Kuliavas"
<[hidden email]> wrote:

>> _Every_ other 'major player' webmail site out there has a SPAM folder
>> (as a special folder).
>
>And what you are supposed to do with that folder? Nothing, if you don't
>have tools that do spam filtering.
>
Don't enable it. I have suggested it is created as an option.
---------------
You can now specify where the default trash folder is located.
On servers where you do not want this, you can set it to anything
and set option 6 to false.
--------
You can now specify where the default draft folder is located.
On servers where you do not want this, you can set it to anything
and set option 9 to false.
---------------

>You use "every other" term to describe something that is present only in
>some email clients.
>

I used the term 'major player'. Meaning the most popular clients.
You name the ones that don't provide the option.
I will name the ones that do.
See who gets the highest count.
Lets use the most popular clients in the lists.

>SquirrelMail is IMAP client. Drafts, Sent and Trash are not standard IMAP
>folders. Only INBOX is standard one. See RFC 3501.
>

So why have the 'option' to create Drafts, Sent and Trash?
Who decided to ignore the RFC here?
I never use Drafts. I use Spam all the time.
I expect I am in the majority here (certainly the case with my user
base).

>You are asking for feature that can be implemented as plugin. Point at
>bugs in 1.4.x code without saying that they are bugs. Claim that you also
>need it for some special feature that is not present in standard code.
>Complain that SquirrelMail configuration script removes variable that is
>not supposed to be used in standard config.php. Ignore special
>configuration file that can be used to store custom variables.
>

None of the plugins implement it the same way as SM treats other
special folders.
I never said there are any bugs.
I never knew about the special configuration file.
If I did not, there are probably plenty of others out there who don't.
I would still prefer it to work without having to use a special
configuration file. If I wanted to edit files I would edit config.php
by hand.
I am not complaining. I am requesting a feature is added.

>SquirrelMail is modular system. This feature can be implemented in plugin.
>Please implement it in plugin. If you can't implement something in plugin,
>we have devel and plugins lists for that.
>

I have enough plugins to keep track of already.
Adding this to core would enable me to lose one of them and save time
editing loads of other files.

So nothing ever gets 'added' to core?

--
Thanks
PajaP


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: [hidden email]
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|

Re: Spam Folder

PajaP
In reply to this post by Brian G. Peterson
On Thu, 7 Sep 2006 05:42:35 -0500, "Brian G. Peterson"
<[hidden email]> wrote:

>I agree that there's some utility to having the "Special Folders" have a
>different sorting and look than regular folders, and this may be
>accomplished by a plugin.  But the name, location, etc of the folder, and
>how they work, is not really a client issue.
>

But surely, if Drafts, Sent and Trash are not standard IMAP
folders then the way the work is the responsibility of the client.
If they are not in the RFC then where does it say it is the
responsibility of the server to handle this?

Is it the client that moves draft messages to the Drafts folder?

--
Thanks
PajaP


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: [hidden email]
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|

Re: Spam Folder

Brian G. Peterson
In reply to this post by PajaP
On Thursday 07 September 2006 12:18, PajaP wrote:
> I am requesting a feature is added.
>
> >SquirrelMail is modular system. This feature can be implemented in
> > plugin. Please implement it in plugin. If you can't implement
> > something in plugin, we have devel and plugins lists for that.

The original poster said that he had already patched the SM source to
allow creation of a Spam folder that is treated just like the other
$special_folders collection in Squirrelmail.

Please provide patch files per the Squirrelmail posting guidelines so that
the SM developer community can discuss adding it to the DEVEL branch of
Squirrelmail.  Patch should be applicable to the current DEVEL CVS HEAD.  
this change will almost certainly not be back-ported to STABLE any time
soon, if it is accepted by the development community.

I believe that the functionality of the special_folders plugin might be
better off implemented in the core, but at least we could look at a
patch, and discuss how it might fit in, and how it might stack up against
other core changes now underway.

Regards,

  - Brian

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: [hidden email]
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|

Re: Spam Folder

Brian G. Peterson
In reply to this post by PajaP
On Thursday 07 September 2006 12:35, PajaP wrote:

> On Thu, 7 Sep 2006 05:42:35 -0500, "Brian G. Peterson" wrote:
> >I agree that there's some utility to having the "Special Folders" have
> > a different sorting and look than regular folders, and this may be
> > accomplished by a plugin.  But the name, location, etc of the folder,
> > and how they work, is not really a client issue.
>
> But surely, if Drafts, Sent and Trash are not standard IMAP
> folders then the way the work is the responsibility of the client.
> If they are not in the RFC then where does it say it is the
> responsibility of the server to handle this?
>
> Is it the client that moves draft messages to the Drafts folder?

Yes, these things are handled by the client.  Not all mail clients handle
them the same way.  As I recall, Thunderbird initially did things very
differently than most other IMAP clients, although their behavior is now
more in-line with standard accepted practices.  

The big issue with Spam folders is that they are handled so differently by
the different spam filtering packages.  Those packages, in general, know
nothing at all about your imap server, and often very little about your
mailbox structure.  So, any integration of 'Spam' as a special folder
will not accomplish much if the system administrator doesn't correctly
set up a spam filtering package, server-side mail filters, and a regular
process for scanning Spam folders and learning spamsign.

I suggested in another post that you apply your changes to the SM CVS
HEAD, and submit a patch.  This would allow the development team to
discuss the *patch* on it's merits, rather than going round and round in
a philosophical discussion.

Regards,
 
    - Brian

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: [hidden email]
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|

Re: Spam Folder

PajaP
In reply to this post by Brian G. Peterson
On Thu, 7 Sep 2006 12:38:31 -0500, "Brian G. Peterson"
<[hidden email]> wrote:

>The original poster said that he had already patched the SM source to
>allow creation of a Spam folder that is treated just like the other
>$special_folders collection in Squirrelmail.
>
>Please provide patch files per the Squirrelmail posting guidelines so that
>the SM developer community can discuss adding it to the DEVEL branch of
>Squirrelmail.  Patch should be applicable to the current DEVEL CVS HEAD.  
>this change will almost certainly not be back-ported to STABLE any time
>soon, if it is accepted by the development community.
>

OK I will have a go at this.
I am not a php developer but all the changes are just adding to lines
that already exist in existing code.

Initially I was using the junk_folder plugin but have now removed this
from my set-up and have made the changes manually to the core files.
I was surprised and only had to make changes in 2 or 3 additional
places to what I had already done.

For example:
In imap_mailbox.php
-------
function isSpecialMailbox( $box ) {
    global $trash_folder, $sent_folder, $draft_folder,

Becomes:
-------
function isSpecialMailbox( $box ) {
    global $trash_folder, $sent_folder, $draft_folder, $spam_folder,
----------------------------------


I still have some work to do as in src/folders.php I still have to
change the line:
------------------
$count_special_folders = 0;

To:
$count_special_folders = -1;
------------------

If I do not make the change then the Trash folder (as the last special
folder in the list) can be deleted or renamed.
I have never been happy about doing this and am sure there must be
somewhere else I should be changing this code.

If anyone has any pointers as to where I should be looking I would, be
grateful :)

I have also never created patch files, though have obviously used
them.
I guess I should learn how to do this as it would make my own
customisation's (after an upgrade) less laborious.

--
Thanks
PajaP


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: [hidden email]
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|

Re: Spam Folder

Tomas Kuliavas
> On Thu, 7 Sep 2006 12:38:31 -0500, "Brian G. Peterson"
> <[hidden email]> wrote:
>
>>The original poster said that he had already patched the SM source to
>>allow creation of a Spam folder that is treated just like the other
>>$special_folders collection in Squirrelmail.
>>
>>Please provide patch files per the Squirrelmail posting guidelines so
>> that
>>the SM developer community can discuss adding it to the DEVEL branch of
>>Squirrelmail.  Patch should be applicable to the current DEVEL CVS HEAD.
>>this change will almost certainly not be back-ported to STABLE any time
>>soon, if it is accepted by the development community.
>>
>
> OK I will have a go at this.
> I am not a php developer but all the changes are just adding to lines
> that already exist in existing code.
>
> Initially I was using the junk_folder plugin but have now removed this
> from my set-up and have made the changes manually to the core files.
> I was surprised and only had to make changes in 2 or 3 additional
> places to what I had already done.
>
> For example:
> In imap_mailbox.php
> -------
> function isSpecialMailbox( $box ) {
>     global $trash_folder, $sent_folder, $draft_folder,
>
> Becomes:
> -------
> function isSpecialMailbox( $box ) {
>     global $trash_folder, $sent_folder, $draft_folder, $spam_folder,
> ----------------------------------

And if you go down 7 lines, you will see
boolean_hook_function('special_mailbox',$box,1) call. Please use plugin.

Folder management issue will be fixed in 1.4.9.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: [hidden email]
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Reply | Threaded
Open this post in threaded view
|

Re: Spam Folder

PajaP
On Thu, 7 Sep 2006 22:05:42 +0300 (EEST), "Tomas Kuliavas"
<[hidden email]> wrote:

>> Initially I was using the junk_folder plugin but have now removed this
>> from my set-up and have made the changes manually to the core files.
>> I was surprised and only had to make changes in 2 or 3 additional
>> places to what I had already done.
>>
>> For example:
>> In imap_mailbox.php
>> -------
>> function isSpecialMailbox( $box ) {
>>     global $trash_folder, $sent_folder, $draft_folder,
>>
>> Becomes:
>> -------
>> function isSpecialMailbox( $box ) {
>>     global $trash_folder, $sent_folder, $draft_folder, $spam_folder,
>> ----------------------------------
>
>And if you go down 7 lines, you will see
>boolean_hook_function('special_mailbox',$box,1) call. Please use plugin.
>

Sorry Tomas, I do not understand this.
I see the line but do not think I need to use the plugin.
I have this implemented and working for some time now.
I get no php or imap errors.
I have also found the answer to my problem of having to set:
$count_special_folders = -1;

Now have it set to zero and none of my special folders can be deleted
or renamed (with some coding in folders.php and new variable
use_spam_folder).

I am now in the process of adding changes to conf.pl to add the option
to use the Spam folder if needed ($default_use_spam_folder).
I do not see any problem with implementing this and it will give
admins the option of defining a Spam folder (or not) and naming it as
they wish.

>Folder management issue will be fixed in 1.4.9.
>

Sorry, this is broken?

I am going to make some patch files.
If SM team are not interested then that is OK by me.
I will use them myself and if anyone else wants them they will be more
than welcome.

--
Thanks
PajaP


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
--
squirrelmail-devel mailing list
Posting Guidelines: http://www.squirrelmail.org/wiki/MailingListPostingGuidelines
List Address: [hidden email]
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
12