On Fri, Oct 5, 2012 at 8:28 PM, Takahiro Kambe <[hidden email]> wrote:
> In message <[hidden email]>
> on Mon, 1 Oct 2012 08:50:55 -0700 (PDT),
> Tomas Kuliavas <[hidden email]> wrote:
>>>> Instead of copying syntax from PHP manual, code should ignore idiocy
>>>> there and use only ENT_COMPAT. ENT_HTML401 introduces backwards
>>>> compatibility break and does nothing.
>>> I don't understand what you meant. ENT_COMPAT or ENT_HTML401 change
>>> default charset of htmlspecialchars()?
>> ENT_HTML401 constant is introduced only in PHP 5.4. Its value is 0. This
>> constant does not change 'htmlspecialchars($string, ENT_COMPAT |
>> ENT_HTML401, $encoding);' call results. Function will follow only ENT_COMPAT
>> specification due to zero value set on ENT_HTML401.
>> Your proposed patch introduces backwards compatibility break. Constant is
>> not available in older PHP versions. It also follows broken PHP
>> documentation synopsis, which PHP developers refused to fix.
> Thanks for your clarification. Hmmmm, I'll check it later...